fix: Fix BatchItem deserialization for non-string primitive values#367
Open
jvaesteves wants to merge 1 commit intomicrosoftgraph:mainfrom
Open
fix: Fix BatchItem deserialization for non-string primitive values#367jvaesteves wants to merge 1 commit intomicrosoftgraph:mainfrom
jvaesteves wants to merge 1 commit intomicrosoftgraph:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
At this moment, when making any BatchRequests, the any primitive value in the results that are not strings are not being properly deserialized. That is because the case grouping was not done properly, and it skips all possible returns inside the switch block, falling into the
return nil, nilloc. This simple change fixes this by properly collapsing these options into a single case, separate by commas.Testing
client.Drives().ByDriveId(driveID).Items().ByDriveItemId(fileID)in a single batchnilYou can use the following snippet to replicate this test. If everything goes as expected, it should not panic at all